#1 Deprecated Request library

Open
opened 7 months ago by Nuggy · 1 comments
Nuggy commented 7 months ago
Collaborator

Note: this is the technical bug tracker, please use other platforms for getting support and starting a (non technical) discussion. See the getting help page for details.

I'm submitting a ...
[x] bug report
[ ] question about the decisions made in the repository

Action taken (what you did)

I compiled a list of all the modules that rely on the deperacated request library,
as well as request-promise. I propose that we replace all instances of request with Got (https://github.com/sindresorhus/got#comparison)

Expected result (what you hoped would happen)

clean current and up to date packages

Actual result (unexpected outcome)

Relying on the request package:

skyn3t-gekko/exchange/wrappers/exmo.js
skyn3t-gekko/importers/exchanges/hitbtc2.js
skyn3t-gekko/importers/exchanges/huobipro.js
skyn3t-gekko/importers/exchanges/okex.js
skyn3t-gekko/plugins/kodi.js
skyn3t-gekko/plugins/pushbullet.js

Relying on the request-promise package:

skyn3t-gekko/exchange/util/genMarketFiles/update-binance.js
skyn3t-gekko/exchange/util/genMarketFiles/update-bitfinex.js
skyn3t-gekko/exchange/util/genMarketFiles/update-coinbase.js
skyn3t-gekko/exchange/util/genMarketFiles/update-coinfalcon.js
skyn3t-gekko/exchange/util/genMarketFiles/update-kraken.js

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, etc)

After examining the list, it looks like we could strip out just about everything but "update-binance.js"

**Note: this is the technical bug tracker, please use other platforms for getting support and starting a (non technical) discussion. See the [getting help page](https://gekko.wizb.it/docs/introduction/getting-help.html) for details.** **I'm submitting a ...** [x] bug report [ ] question about the decisions made in the repository **Action taken** (what you did) I compiled a list of all the modules that rely on the deperacated request library, as well as request-promise. I propose that we replace all instances of request with Got (https://github.com/sindresorhus/got#comparison) **Expected result** (what you hoped would happen) clean current and up to date packages **Actual result** (unexpected outcome) Relying on the request package: skyn3t-gekko/exchange/wrappers/exmo.js skyn3t-gekko/importers/exchanges/hitbtc2.js skyn3t-gekko/importers/exchanges/huobipro.js skyn3t-gekko/importers/exchanges/okex.js skyn3t-gekko/plugins/kodi.js skyn3t-gekko/plugins/pushbullet.js Relying on the request-promise package: skyn3t-gekko/exchange/util/genMarketFiles/update-binance.js skyn3t-gekko/exchange/util/genMarketFiles/update-bitfinex.js skyn3t-gekko/exchange/util/genMarketFiles/update-coinbase.js skyn3t-gekko/exchange/util/genMarketFiles/update-coinfalcon.js skyn3t-gekko/exchange/util/genMarketFiles/update-kraken.js **Other information** (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, etc) After examining the list, it looks like we could strip out just about everything but "update-binance.js"
Nuggy self-assigned this 7 months ago
Nuggy removed their assignment 7 months ago

For the sole purpose (as you said in mumble VC) of using HTTP/2 you can instead use the built in package 'http2'

https://nodejs.org/api/http2.html#http2_http_2

For the sole purpose (as you said in mumble VC) of using HTTP/2 you can instead use the built in package 'http2' https://nodejs.org/api/http2.html#http2_http_2
Sign in to join this conversation.
No Label
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Depends on
#2 [Metadata] Futurama - Specials season
zer0/skymedia-metadata
Loading…
There is no content yet.